Making the scope property as fully qualified resource Id #18165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Test this change out locally with the following install scripts (Action run 19252787923) VSCode
Azure CLI
|
subha-sa
requested review from
anthony-c-martin,
jeskew,
majastrz and
shenglol
Contributor
Dotnet Test Results 96 files - 48 96 suites - 48 42m 8s ⏱️ - 28m 23s Results for commit a22ca09. ± Comparison against base commit 066c054. This pull request removes 1924 and adds 661 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Comment on lines
102
to
110
| public void EmitFullyQualifiedResourceId(DeclaredResourceMetadata resource, IndexReplacementContext? indexContext) | ||
| { | ||
| var converterForContext = converter.GetConverter(indexContext); | ||
|
|
||
| var fullyQualifiedResourceId = converterForContext.GetFullyQualifiedResourceId(resource); | ||
| var serialized = ExpressionSerializer.SerializeExpression(fullyQualifiedResourceId); | ||
|
|
||
| writer.WriteValue(serialized); | ||
| } |
Member
There was a problem hiding this comment.
Unless I'm mistaken, the implementation looks identical to the existing function EmitResourceIdReference - can we commonize rather than creating a new one?
Contributor
Author
There was a problem hiding this comment.
Thanks, for pointing this out. I have renamed the existing one, just to be more explicit.
jeskew
approved these changes
Oct 30, 2025
| "type": "Microsoft.Authorization/locks", | ||
| "apiVersion": "2016-09-01", | ||
| "scope": "[extensionResourceId(format('Microsoft.Storage/storageAccounts/{0}', format('{0}single-resource-name', parameters('name'))), 'Microsoft.Authorization/locks', 'single-resource-lock')]", | ||
| "scope": "[extensionResourceId(resourceId('Microsoft.Storage/storageAccounts', format('{0}single-resource-name', parameters('name'))), 'Microsoft.Authorization/locks', 'single-resource-lock')]", |
Member
There was a problem hiding this comment.
This change appears to be fixing a bug in that extensionResourceId assumes the first parameter is a fully qualified ID. I tried deploying a template with the output [extensionResourceId('Microsoft.Authorization/roleAssignments/foo', 'RP.Namespace/type', 'bar')] at a few scopes, and it always evaluates to /Microsoft.Authorization/roleAssignments/foo/providers/RP.Namespace/type/bar. So this is not strictly a no-op but is a desired change. We must not have caught this before because extension resources on extension resources aren't very common outside of test scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR, makes scope property fully qualified resource Id.
Checklist
Microsoft Reviewers: Open in CodeFlow